Code formatter #305
Merged
Code formatter #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For me this is easier to read, so I'm for the change. |
|
Maybe it is good to rebase and merge #235 before we merge this. Other PRs don't seem ready to merge. |
|
I'll rebase |
seriyps
force-pushed
the
code-formatter
branch
from
a29ef7d to
c6602db
Compare
|
Looks good to me! @arjan are you ok? |
|
@seriyps Go ahead and merge. Then we can ask @Maria-12648430 to check her pull request #307 |
mworrell
approved these changes
Feb 11, 2022
|
Thanks! 🎉 |
Heeey! Don't make me your guinea pig 😅 j/k There are some merge conflicts, as expected. I'll have to look at them more closely later, busy right now 😉 |
|
Sorry 😇
|
|
Glad this got merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a proof of concept to start the discussion.
Pros:
Cons:
git blamewill be confusing by default (unless one doesgit config --global blame.ignoreRevsFile .git-blame-ignore-revs, which is quite common solution)rebar3 fmtover the fork's source tree). But right now we don't have that many open PRs.